Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Regression] replaceIn doesn't replace #10881

Closed
mitchlloyd opened this issue Apr 15, 2015 · 2 comments · Fixed by #10883
Closed

[Regression] replaceIn doesn't replace #10881

mitchlloyd opened this issue Apr 15, 2015 · 2 comments · Fixed by #10883
Labels
Bug Regression

Comments

@mitchlloyd
Copy link
Contributor

According to the documentation, replaceIn should replace the content of the given element.

This seems to work in 1.10.0

But in 1.11.1 it does not.

Looking for confirmation that this is a bug and then I would be happy to investigate and open a PR.

Edit: Narrowed this down to Ember v1.11.0-beta.2 where the bug was introduced. Probably this commit
@mitchlloyd
Copy link
Contributor Author

PR coming soon

mitchlloyd added a commit to mitchlloyd/ember.js that referenced this issue Apr 15, 2015
@mitchlloyd
Fix replace in
f373f87 
Resolves emberjs#10881
@mitchlloyd mitchlloyd mentioned this issue Apr 15, 2015
Merged
@mitchlloyd
Copy link
Contributor Author

Closed in favor of PR #10883

mitchlloyd added a commit to mitchlloyd/ember.js that referenced this issue Apr 15, 2015
@mitchlloyd
[BUGFIX beta] Fix replace in
d9965f6 
Resolves emberjs#10881
rwjblue pushed a commit that referenced this issue May 2, 2015
@mitchlloyd @rwjblue
[BUGFIX beta] Fix replace in
7eed446 
Resolves #10881
(cherry picked from commit d9965f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix replace in mitchlloyd/ember.js
2 participants
@mitchlloyd @fivetanley