link-to current-when cannot be supplied as true as per docs
#12512
Comments
|
The fact that it doesn't work seems like a regression, and I think we should make the docs correct. |
ssured
added a commit
to ssured/ember.js
that referenced
this issue
Nov 20, 2015
|
@rlivsey Did you find a work around for this? |
|
I think #12630 should fix this. |
|
@beerlington @rwjblue sorry I got sidetracked after opening this and then seem to have completely forgotten about it! #12630 looks like it should do the trick though (could do with a test or two though to prevent future regressions) |
|
I'll keep an eye on that, thanks! |
ssured
added a commit
to ssured/ember.js
that referenced
this issue
Jan 15, 2016
|
Fixed by #12344. |
whatthewhat
added a commit
to whatthewhat/ember.js
that referenced
this issue
Jan 18, 2017
As the docs say, `A link will be active if current-when is true`. Looks like this might have been broken since 1.13 and emberjs#12344 did not seem to actually fix this particular bug. Related issues: - emberjs#12512 - emberjs#12630 (fix was not merged) - emberjs#12296
whatthewhat
added a commit
to whatthewhat/ember.js
that referenced
this issue
Jun 26, 2017
As the docs say, `A link will be active if current-when is true`. Looks like this might have been broken since 1.13 and emberjs#12344 did not seem to actually fix this particular bug. Related issues: - emberjs#12512 - emberjs#12630 (fix was not merged) - emberjs#12296
locks
added a commit
that referenced
this issue
Aug 16, 2017
# This is the 1st commit message: typo in comment # The commit message #2 will be skipped: # indent yuidoc comment # The commit message #3 will be skipped: # remove IE8 test # The commit message #4 will be skipped: # remove commented out test # The commit message #5 will be skipped: # use file path and add imports # # Used RFC #176 modules API for imports. # Also cleaned up some of the globals-mode usage. # The commit message #6 will be skipped: # clean up more globals style documentation # The commit message #7 will be skipped: # Updates blueprints # The commit message #8 will be skipped: # remove extra type check # The commit message #9 will be skipped: # [BUGFIX beta] Reusing element causes problems in Safari # # When testing allowed input types, in some versions of Safari the type # cannot be change to `file` if previously set to a different one. # # Fixes #14727 # The commit message #10 will be skipped: # [DOC release]missed code block added # The commit message #1 will be skipped: # [DOC release] Update wait.js - Add missing backticks to code snippet. # The commit message #2 will be skipped: # use safe `toString` for array content in `mixins/array` # The commit message #3 will be skipped: # avoid expanding already expanded property key in computed.sort # The commit message #4 will be skipped: # avoid expanding already expanded property key in reduceMacro/arrayMacro/multiArrayMacro # The commit message #5 will be skipped: # [DOC release] Make `Ember.expandProperties` public # The commit message #6 will be skipped: # reuse meta `arrayContentDidChange` # The commit message #7 will be skipped: # replace `throw` with assertion in `enumerable` # The commit message #8 will be skipped: # [BUGFIX beta] Allow boolean values for current-when # # As the docs say, `A link will be active if current-when is true`. # Looks like this might have been broken since 1.13 and #12344 # did not seem to actually fix this particular bug. # # Related issues: # # - #12512 # - #12630 (fix was not merged) # - #12296 # The commit message #9 will be skipped: # remove unused imports # The commit message #10 will be skipped: # [DOC] Improve Ember.isEmpty # The commit message #1 will be skipped: # micro optimization in `enumerable`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The docs specify that:
However, this currently does not appear to be the case, as
current-whenis always treated as a string andsplitcalled on it.Should the docs be updated to reflect that this is expected to just be a string separated list of route names, or should
truework as documented? I shall PR either way!The text was updated successfully, but these errors were encountered: