Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Ember.Binding #13243

Closed
2 tasks
mmun opened this issue Apr 4, 2016 · 9 comments
Closed
2 tasks

Deprecate Ember.Binding #13243

mmun opened this issue Apr 4, 2016 · 9 comments

Comments

@mmun
Copy link
Member

mmun commented Apr 4, 2016

This issue tracks the deprecation of Ember.Binding (and *Binding properties). They've not been needed for a very long time. The existing use cases are covered by computeds and service injections.

  • Add an entry in the deprecation guides
  • Add deprecations to core
    • Trigger a deprecation when the binding connects so that we can provide better upgrade suggestions. If its oneWay, suggest using a readOnly computed. Otherwise, suggest an alias. If the binding is to a global, suggest using a service.
@rwjblue
Copy link
Member

rwjblue commented Apr 4, 2016

@mmun - Sounds like a good plan, thanks for working on it...

@mmun mmun self-assigned this Apr 4, 2016
@krisselden
Copy link
Contributor

@mmun this alternatives are extend time, bindings are allowed at create time, I don't think we need an alternative, I'm just pointing it out for the guide.

@mmun
Copy link
Member Author

mmun commented Apr 9, 2016

Good point

@mmun mmun removed their assignment Apr 14, 2016
@mmun
Copy link
Member Author

mmun commented Apr 14, 2016

If someone wants to give this a shot in the meantime, please do!

@pittst3r
Copy link
Contributor

I'll take a stab!

@mmun
Copy link
Member Author

mmun commented Apr 24, 2016

@robbiepitts Thanks so much! Hit me up in the #dev-ember channel of the community Slack if you have any trouble.

@Serabe
Copy link
Member

Serabe commented May 13, 2016

@mmun I see both PRs have been merged. Is there something left to do or can this be closed?

Thank you!

@pittst3r
Copy link
Contributor

@Serabe This can be closed, thanks!

@mmun mmun closed this as completed May 13, 2016
@mmun
Copy link
Member Author

mmun commented May 13, 2016

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants