[DEPRECATE] Deprecate Ember.Binding #13424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pittst3r
force-pushed
the
deprecate-ember-binding
branch
from
e1c7604
to
45b542c
Compare
|
Looks like I missed some tests. Update forthcoming. |
pittst3r
force-pushed
the
deprecate-ember-binding
branch
2 times, most recently
from
cc4b6c5
to
d8444bc
Compare
pittst3r
changed the title
pittst3r
force-pushed
the
deprecate-ember-binding
branch
from
21484f5
to
c0cc03d
Compare
|
Links to guide added and commits squashed. PR for deprecation guide referenced above. 😀 |
| @@ -250,11 +250,17 @@ moduleFor('Helpers test: {{unbound}}', class extends RenderingTest { | |||
| return a.join(''); | |||
| }); | |||
|
|
|||
| this.render(`{{unbound (repeat foo count=bar)}} {{repeat foo count=bar}} {{unbound (repeat foo count=2)}} {{repeat foo count=4}}`, { | |||
| foo: 'X', | |||
| numRepeatsBinding: 'bar', | |||
There was a problem hiding this comment.
Is this even used in this test? I don't see any usage of numRepeats?
There was a problem hiding this comment.
Good find, doesn't look like it. Also doesn't appear to me to be relevant to the test. Tests remain green after removal of that and the deprecation expectation.
I will amend my commit with these changes.
pittst3r
force-pushed
the
deprecate-ember-binding
branch
from
c0cc03d
to
bc8903f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #13243.
This is ready for review but not merge. Still to be done is the deprecation guide update. Once I finish that I will update the links in this PR and squash.
cc @mmun