Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mouseenter: Object doesn't support property or method 'contains' #17225

Closed
amk221 opened this issue Nov 22, 2018 · 5 comments
Closed

mouseenter: Object doesn't support property or method 'contains' #17225

amk221 opened this issue Nov 22, 2018 · 5 comments
Labels
Bug Has PR

Comments

@amk221
Copy link
Contributor

amk221 commented Nov 22, 2018 •
edited
Loading

With "jquery-integration": false I'm getting Object doesn't support property or method 'contains' in IE11. It may have something to do with SVG.

screenshot 2018-11-22 at 12 22 49

ember.js/packages/@ember/-internals/views/lib/system/event_dispatcher.js

Line 338 in 6264318

(!related || (related !== target && !target.contains(related)))


Having to delay our jQuery-removal celebrations :)
@rwjblue
Copy link
Member

rwjblue commented Nov 23, 2018

Thanks for reporting!

@simonihmig - Any ideas off the top of your head?

@simonihmig
Copy link
Contributor

@amk221 I assume this was an mouseenter event, not mouseover as in your title, right?

It may have something to do with SVG.

Indeed. I quickly booted my VM with IE11, and it seems it doesn't support Node#contains() on SVG elements. 🙄

I had a quick look how the jQuery-based implementation works around this, and it seams jQuery (or rather Sizzle) has a fallback implementation here: https://github.com/jquery/jquery/blob/e743cbd28553267f955f71ea7248377915613fd9/external/sizzle/dist/sizzle.js#L860-L868

I guess we can flag this as a bug then! I can try to provide a fix hopefully soon...

@amk221
Copy link
Contributor Author

amk221 commented Nov 23, 2018

Ah @simonihmig, yes - thank you!

@amk221 amk221 changed the title Mouseover Object doesn't support property or method 'contains' mousenter: Object doesn't support property or method 'contains' Nov 23, 2018
@amk221 amk221 changed the title mousenter: Object doesn't support property or method 'contains' mouseenter: Object doesn't support property or method 'contains' Nov 23, 2018
simonihmig added a commit to simonihmig/ember.js that referenced this issue Nov 24, 2018
@simonihmig
[BUGFIX beta] fix mouseEnter/Leave event delegation w/o jQuery for SV…
5676c4b 
…G elements in IE11

IE11 does not support `Node#contains()` on SVG elements, so in that case a custom fallback implementation is used

Fixes emberjs#17225
@simonihmig simonihmig mentioned this issue Nov 24, 2018
Merged
@pixelhandler
Copy link
Contributor

pixelhandler commented Nov 30, 2018 •
edited
Loading

@rwjblue @simonihmig is ie11 w/o jQuery officially supported ? if so, this is a bug correct?

simonihmig added a commit to simonihmig/ember.js that referenced this issue Nov 30, 2018
@simonihmig
[BUGFIX beta] fix mouseEnter/Leave event delegation w/o jQuery for SV…
82ee67f 
…G elements in IE11

IE11 does not support `Node#contains()` on SVG elements, so in that case a custom fallback implementation is used

Fixes emberjs#17225
@rwjblue
Copy link
Member

rwjblue commented Dec 6, 2018

Yep, updated the labels.

simonihmig added a commit to simonihmig/ember.js that referenced this issue Dec 6, 2018
@simonihmig
[BUGFIX beta] fix mouseEnter/Leave event delegation w/o jQuery for SV…
62d6096 
…G elements in IE11

IE11 does not support `Node#contains()` on SVG elements, so in that case a custom fallback implementation is used

Fixes emberjs#17225
kategengler pushed a commit that referenced this issue Dec 6, 2018
@simonihmig @kategengler
[BUGFIX beta] fix mouseEnter/Leave event delegation w/o jQuery for SV…
e691bd0 
…G elements in IE11

IE11 does not support `Node#contains()` on SVG elements, so in that case a custom fallback implementation is used

Fixes #17225

(cherry picked from commit 62d6096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rwjblue @pixelhandler @amk221 @simonihmig