Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUEST] Remove jQuery #17476

Closed
9 of 16 tasks
simonihmig opened this issue Jan 12, 2019 · 10 comments
Closed
9 of 16 tasks

[QUEST] Remove jQuery #17476

simonihmig opened this issue Jan 12, 2019 · 10 comments
Labels

Comments

@simonihmig
Copy link
Contributor

simonihmig commented Jan 12, 2019

This is an issue to track the progress on implementing the RFC386 to remove jQuery by default.

Work items

Deprecation phase (3.x)

ember.js

@ember/jquery

ember-cli

@ember/test-helpers

ember-cli-babel

ember-data

ember-fetch

  • Provide a replacement API for jQuery's prefilter

Website

Removal phase (4.0)

ember.js

  • remove deprecated functions
  • remove the jQuery specific code paths in the EventDispatcher

Collaboration

If someone wants to start work on a specific item, please post this here so I can update the list.

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2019

Thanks for putting the meta issue together @simonihmig!

@rwjblue rwjblue added the Meta label Jan 12, 2019
@simonihmig
Copy link
Contributor Author

@chriskrycho you mentioned in Discord that you could take over the ember-fetch/prefilter part. Is this still the case, can I assign you to this task? 👆

@chriskrycho
Copy link
Contributor

Depends on when we want it done by. I'm starting a new job two weeks from today (very much still in Ember land), so I'm in wrapping-up-all-the-things mode now and will be in starting-all-the-things mode for the first couple weeks after that. I'm happy to do it, but given all fo that it'll probably be the second or third week of February before it's viable.

@bobisjan
Copy link
Contributor

Thanks for this issue 👏!

I have a question if FastBoot should be included in this quest with deprecating and removing

@rwjblue
Copy link
Member

rwjblue commented Jan 23, 2019

@simonihmig - We need to add svelte support to the deprecations added in #17489 and #17488. The basic process is:

  • add an entry in packages/@ember/deprecated-features/index.ts
  • import that constant and use it to wrap all deprecated code paths in an if (I think this actually means all code that would be using the preexisting jQueryDisabled flag also gets the new guard)

Some recent examples:

@dcyriller
Copy link
Contributor

@simonihmig you may want to add a lock on the item: "Update app blueprint"

@simonihmig
Copy link
Contributor Author

@dcyriller cool, done! 👍

I am just thinking, switching the app blueprints to remove jQuery by default is certainly blocked by the outstanding ember-data issue. If that is not resolved by the time Ember 3.9 lands, we should probably do an intermediate step and update the blueprints to just bump the @ember/jquery version to 0.6.0, so an ember new app does not see any deprecations. And then switch to no jQuery mode as soon as ember-data is ready. @rwjblue agree?

@dcyriller
Copy link
Contributor

@simonihmig understood! By chance, ember-cli/ember-cli#8396 would implement this intermediate step.

@rwjblue
Copy link
Member

rwjblue commented Feb 2, 2019

@simonihmig agree, I think that’s being done in ember-cli/ember-cli#8396

@simonihmig
Copy link
Contributor Author

Closing this in favor of emberjs/rfc-tracking#3!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants
@rwjblue @bobisjan @simonihmig @chriskrycho @dcyriller and others