query-params-new: error in paramsFor()

[florent-blanvillain]

Hi,

I get an error in paramsFor() at this line:
https://github.com/emberjs/ember.js/blob/master/packages/ember-routing/lib/system/route.js#L1321

params[colonized.split(':').pop()] = value;

"Sometimes", params is an Ember.Object so that I get:
Assertion Failed: You must use Ember.set() to access this property (of [object Object])

It happened after a transition at the same level (ie in the same router resource).

[florent-blanvillain]

I know what you're talking about, I had the same problem : 'query-params-new' feature is partially activated unless the flag is set before ember loads.
But here this issue is inside the paramsFor method (but it might come from elsewhere).

[florent-blanvillain]

As a quick fix, changing

params[colonized.split(':').pop()] = value;

by

set(params, colonized.split(':').pop(), value);

works for me.

[raytiley]

@florent-blanvillain could you create a jsbin showing the issue?

[florent-blanvillain]

Yes, here it is :
http://jsbin.com/UyuRoBiv/1/

[raytiley]

I'm dealing w/ a really slow internet connection so I can't really dig into this at the moment. My gut tells me that using set() shouldn't be necessary there. The queryParams object comes from router.js / route-recognizer which are both Ember agnostic libraries. Therefore those objects shouldn't be Ember.objects.

I'll try to look at this tonight if I can.

cc @machty