Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add activate and deactivate events to Ember.Route #4923

Closed
machty opened this issue May 23, 2014 · 6 comments · Fixed by #5569
Closed

Feature: add activate and deactivate events to Ember.Route #4923

machty opened this issue May 23, 2014 · 6 comments · Fixed by #5569
Assignees
Labels

Comments

@machty
Copy link
Contributor

machty commented May 23, 2014

Would be nice if mixins that add behavior to Ember.Route didn't have to use _super all over the place.

pushToNavigation: function() {
   ... blahdeblah
}.on('activate')
@rwjblue
Copy link
Member

rwjblue commented May 23, 2014

Agreed. This would definitely be preferable.

@gpoitch
Copy link
Contributor

gpoitch commented May 23, 2014

throw in willTransition too

@machty
Copy link
Contributor Author

machty commented May 24, 2014

nothing to kill or die for
and willTransition too

@wagenet
Copy link
Member

wagenet commented Aug 6, 2014

@machty ping.

@salzhrani
Copy link

Sound super, Thank you @machty

@pangratz
Copy link
Member

pangratz commented Sep 9, 2014

I've created a PR for firing the activate and deactivate events, additional to the current hooks on Ember.Route.

Regarding the willTransition event, as discussed above: I think this is handled by the willLeave action proposed in #4760.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants