Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE ember-routing-will-change-hooks] finer-grain transition hooks #4760

Merged
merged 1 commit into from
Apr 24, 2014

Conversation

machty
Copy link
Contributor

@machty machty commented Apr 23, 2014

Brought to you by @ef4, and demonstrated at his EmberConf talk:

http://confreaks.com/videos/3302-emberconf2014-animations-and-transitions-in-an-ember-app

See this router.js PR for details:

tildeio/router.js#89

TL;DR adds willLeave and willChangeModel hooks (not that Ember renames the router.js willChangeContext hook to willChangeModel)

machty added a commit that referenced this pull request Apr 24, 2014
[FEATURE ember-routing-will-change-hooks] finer-grain transition hooks
@machty machty merged commit 13fb4d7 into emberjs:master Apr 24, 2014
@stefanpenner stefanpenner mentioned this pull request Apr 25, 2014
8 tasks
@tomdale
Copy link
Member

tomdale commented Aug 15, 2014

Allegedly, this is no longer used in Liquid Fire. We want to wait to see if there is an existing primitive that can be used before adding more API surface area. @machty will talk to @ef4.

@stefanpenner
Copy link
Member

@ef4 just confirming, you found a better way to do this?

@ef4
Copy link
Contributor

ef4 commented Oct 11, 2014

liquid-fire doesn't need this.

But this is not an animation-specific feature, and I think it still fills a gap in the API. In my own app I have use cases for it, for things like a "do you really want to leave this screen without saving?" alert when there are nested child routes in play.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants