Enable sourcemap support for Ember development. #10548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -20,6 +20,7 @@ script: | |||
|
|
|||
| env: | |||
| global: | |||
| - DISABLE_SOURCE_MAPS=true | |||
There was a problem hiding this comment.
This ensures that Travis builds do not contain sourcemaps. We will remove this in the future when all kinks in the ember-cli sourcemap pipeline are ironed out.
rwjblue
force-pushed
the
enable-sourcemaps-for-dev
branch
from
a2608ef
to
617818a
Compare
This is useful while developing on Ember, and we may possibly publish the maps to `bower`, S3, etc in the future, but we need to be careful to not cause many errors/warnings while building Ember CLI (if the `.map` file is referenced but not present it causes a console warning).
rwjblue
force-pushed
the
enable-sourcemaps-for-dev
branch
from
617818a
to
ad79c1e
Compare
rwjblue
added a commit
that referenced
this pull request
Feb 28, 2015
Enable sourcemap support for Ember development.
tricknotes
added a commit
to tricknotes/ember.js
that referenced
this pull request
Apr 2, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful while developing on Ember, and we may possibly publish the maps to
bower, S3, etc in the future, but we need to be careful to not cause many errors/warnings while building Ember CLI (if the.mapfile is referenced but not present it causes a console warning).