[BUGFIX release] Ensure that inline {{link-to}} does not cause a crash. #10553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Much better! |
mmun
added a commit
that referenced
this pull request
Mar 1, 2015
[BUGFIX release] Ensure that inline {{link-to}} does not cause a crash.
|
How did this crash the browser? I'm asking because I still see a browser crash that may be similar, and I don't understand this diff. |
|
@ef4 - The stream for the bound title (in inline form), was never unsubscribed and it triggered a re-render, which then kept growing the streams (which were never cleaned up) and eventually (after 10 or so times) would completely freeze and crash. |
|
@ef4 - Demo with v1.10.0: http://emberjs.jsbin.com/berebe/4/edit?html,js |
|
Ok, I suspect the crash I was getting is unrelated. I don't think it's ember's fault at all, I think that Chrome has a bug when dealing with CSS3 transforms scaled down near zero size. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10360.