Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bound outlet names #11029

Merged
merged 1 commit into from
May 5, 2015
Merged

Allow bound outlet names #11029

merged 1 commit into from
May 5, 2015

Conversation

ef4
Copy link
Contributor

@ef4 ef4 commented May 5, 2015

Bound outlet names actually work fine without any additional work. They
were just disallowed due to a very old assert that was introduced back
when we were first standardizing the use of quoted strings to represent
literals.

This drops the assertion and adds a test that shows bound outlet names
work.

Bound outlet names actually work fine without any additional work. They
were just disallowed due to a very old assert that was introduced back
when we were first standardizing the use of quoted strings to represent
literals.

This drops the assertion and adds a test that shows bound outlet names
work.
@rwjblue
Copy link
Member

rwjblue commented May 5, 2015

👍

@ef4
Copy link
Contributor Author

ef4 commented May 5, 2015

Sauce labs timed out.

@rwjblue
Copy link
Member

rwjblue commented May 5, 2015

Restarted.

rwjblue added a commit that referenced this pull request May 5, 2015
@rwjblue rwjblue merged commit fd0cb35 into emberjs:master May 5, 2015
@john-kurkowski
Copy link

Does this indicate a breaking change in the 1.x series? {{outlet foo}} used to be equivalent to {{outlet "foo"}}. I'm upgrading an Ember 1.8 app to 1.13 and was lucky I came across this in 1.13's changelog. It gave me a hint why some of my outlets were not rendering at all: they were unquoted and thus assumed bound to some undefined property. The assert would've saved me some time.

@ef4
Copy link
Contributor Author

ef4 commented Dec 28, 2015

I'm pretty sure unquoted outlet names already generated a warning in 1.8, yes?

@john-kurkowski
Copy link

I hadn't noticed any warnings then. Quote-less outlet names were officially deprecated in 1.10. I wouldn't have thought that meant removal in the 1.x series though. Worth noting in the changelog? I'm not sure it's this PR per se. At the very least, hope Google leads others with the same issue to here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants