Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX BETA] Fix initial selection for select with optgroup #11161

Merged
merged 1 commit into from
May 15, 2015
Merged

[BUGFIX BETA] Fix initial selection for select with optgroup #11161

merged 1 commit into from
May 15, 2015

Conversation

kamalaknn
Copy link

Using Ember.Select with optionGroupPath did not set the initial value from attrs.value. As seen in the reproduction here.

Fixed by passing view.value to SelectOptGroupView( which gets passed to parentValue for SelectOptionView here )

@mixonic
Copy link
Member

mixonic commented May 15, 2015

Excellent, thank you @kamalaknn

mixonic added a commit that referenced this pull request May 15, 2015
@mixonic
Merge pull request #11161 from kamalaknn/bugfix_select_optgroup
7b33514 
[BUGFIX BETA] Fix initial selection for select with optgroup
@mixonic mixonic merged commit 7b33514 into emberjs:master May 15, 2015
@kamalaknn kamalaknn deleted the bugfix_select_optgroup branch May 15, 2015 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kamalaknn @mixonic