[BUGFIX beta] Fix issue with multiple actions in a single element. #11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In prior versions of Ember multiple `{{action}}` helpers were
not able to be attached to a single element. This was primarily due
to the way that the actions were wired (via `data-ember-action`
attribute).
That original limitation seems like a bug, and this commit enables usage
of multiple actions in a single DOM element by having the
private `ActionManager` keep its internal representation of "actions for
a given action ID" as an array and iterating that array when an event
occurs.
|
This has annoyed me for years. ✋ 5️⃣ |
|
@lukemelia I don't think it annoys people as much if they don't work on mobile, but yeah, it's been since day one of using Ember for me (nearly two years now). |
rwjblue
added a commit
that referenced
this pull request
Jun 8, 2015
[BUGFIX beta] Fix issue with multiple actions in a single element.
|
This is awesome! 🎆 👍 |
|
👍 |
AlfaroLore
referenced
this pull request
in balinterdi/ember-cli-star-rating
Jul 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In prior versions of Ember multiple
{{action}}helpers were not able to be attached to a single element. This was primarily due to the way that the actions were wired (viadata-ember-actionattribute).That original limitation seems like a bug, and this commit enables usage of multiple actions in a single DOM element by having the private
ActionManagerkeep its internal representation of "actions for a given action ID" as an array and iterating that array when an event occurs.The following example is enabled after this PR: