Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] Remove deprecated CP semantics #11438

Merged
merged 1 commit into from
Jun 14, 2015

Conversation

cibernox
Copy link
Contributor

I can't tell how long I've been waiting for this moment.

@stefanpenner
Copy link
Member

yay

@stefanpenner
Copy link
Member

kicking sauce labs

@cibernox
Copy link
Contributor Author

As a side note, a backwards compatible change is that the setter function always receives the oldValue as 3rd argument.
Formerly it used to check the arity of the setter function to invoke it with or without the 3rd argument. I cannot think on a single good reason to do that now.

@stefanpenner
Copy link
Member

@krisselden / @mmun can you review? I flew a red-eye last night, my judgement is likely not the best right now 😴 :

@rwjblue
Copy link
Member

rwjblue commented Jun 13, 2015

Let's prefix with [CLEANUP beta](seems better than nothing and will make changelog work easier).

@cibernox cibernox changed the title Remove deprecated CP semantics [CLEANUP beta] Remove deprecated CP semantics Jun 13, 2015
mixonic added a commit that referenced this pull request Jun 14, 2015
[CLEANUP beta] Remove deprecated CP semantics
@mixonic mixonic merged commit 6cb71d7 into emberjs:master Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants