Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make linkChild idempotent #11685

Merged
merged 2 commits into from
Jul 11, 2015
Merged

Conversation

stefanpenner
Copy link
Member

  • find related tests
  • add a test to ensure we don't regress

while looking at @sandstrom https://github.com/sandstrom/initial-render-components I noticed, copious amounts of u needed changes events where happening.

That example although synthetic, does indicate death a a thousand papercuts scenario. With a large 15 -> 20% GC cycle. GC is just the result of us allocating to much.

Anyways, back on topic. to many change events where happening.These changes have additional side-affects, but the main one is sendEvent itself, which seems to have drop by 15% -> 25% with this change.

I really wouldn't call home about this one, but it helps a teeny tiny bit.

@stefanpenner stefanpenner changed the title prevent parentView from being invalidated on initial render as it cau… make linkChild idempotent Jul 8, 2015
@stefanpenner stefanpenner force-pushed the component-cleanup branch 2 times, most recently from 60ab59f to 77f5156 Compare July 10, 2015 21:18
@stefanpenner
Copy link
Member Author

@tomdale / @wycats

@wycats
Copy link
Member

wycats commented Jul 11, 2015

r+

rwjblue added a commit that referenced this pull request Jul 11, 2015
@rwjblue rwjblue merged commit fb49fa0 into emberjs:master Jul 11, 2015
@rwjblue rwjblue deleted the component-cleanup branch July 11, 2015 02:54
@sandstrom
Copy link
Contributor

Great! I've updated the repo to use this change.

I really appreciate that you are looking into this! It'll make the views-to-components paradigm better in apps with a lot of components.

(for people stumbling upon this commit, more details can be found here: #11502 (comment))

@stefanpenner
Copy link
Member Author

I really appreciate that you are looking into this! It'll make the views-to-components paradigm better in apps with a lot of components.

np. The large chunk of this type of waste still needs to be addressed (the attrs object, and related backwards compat) I have been noodling on it, and think there is a way to sort it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants