Revert "[CLEANUP beta] Remove support for reversed args in Ember.Obse… #11824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
added a commit
that referenced
this pull request
Jul 20, 2015
…arguments_order_in_observer Revert "[CLEANUP beta] Remove support for reversed args in Ember.Obse…
rwjblue
deleted the
revert-11782-remove_alternate_arguments_order_in_observer
branch
|
Ooops |
|
cc @teddyzeenny |
|
@cibernox - No worries! |
|
That makes me think. Will be at some point a ember-inspector 2 that removes 1.X compatibility? |
|
The new inspector version is out - it no longer uses the old observer args. |
|
That we can revert the revert for 2.0 stable? |
|
Nah, it doesn't cost us much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #11782. The release version of the ember-inspector used the deprecated format. It doesn't cost us much to keep the old version around with the deprecation.
Fixes #11803.