Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix contextual components handling invalid component paths #12422

Merged
merged 1 commit into from
Oct 5, 2015

Conversation

Serabe
Copy link
Member

@Serabe Serabe commented Oct 1, 2015

Contextual components show a message when passed null or unknown component
paths.

registry.register(
'template:components/-hindi',
compile(`Namaste`)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the above lines of this test be removed? They seem to be un-used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Contextual components show a message when passed null or unknown component
paths.
@Serabe Serabe force-pushed the feature/null-closure-components branch from 200b06a to 4984afa Compare October 5, 2015 18:47
@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2015

#12440 fixed the node-land tests, merging...

rwjblue added a commit that referenced this pull request Oct 5, 2015
[BUGFIX] Fix contextual components handling invalid component paths
@rwjblue rwjblue merged commit 736fdea into emberjs:master Oct 5, 2015
@rwjblue
Copy link
Member

rwjblue commented Oct 5, 2015

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants