Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document getOwner and setOwner #12562

Merged
merged 1 commit into from
Nov 6, 2015
Merged

Document getOwner and setOwner #12562

merged 1 commit into from
Nov 6, 2015

Conversation

mixonic
Copy link
Member

@mixonic mixonic commented Nov 5, 2015

Normally I would include a preview here, but I cannot seem to get a preview of the docs locally :-/

Framework objects in an Ember application (components, services, routes, etc.)
are created via a factory and dependency injection system.

`getOwner` fetches the owner object responsible for a instance. This can
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an instance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gracias

export function getOwner(object) {
return object[OWNER];
}

/**
`setOwner` forces a new owner on a given object instance. This is primarially
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/primarially/primarily/

@mixonic
Copy link
Member Author

mixonic commented Nov 6, 2015

Thanks @dgeb, updated.

@dgeb
Copy link
Member

dgeb commented Nov 6, 2015

Thank you @mixonic for tackling these docs. LGTM 👍

rwjblue added a commit that referenced this pull request Nov 6, 2015
Document getOwner and setOwner
@rwjblue rwjblue merged commit 3486f33 into emberjs:master Nov 6, 2015
@mixonic mixonic deleted the getOwnerDoc branch November 6, 2015 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants