Remove registering unncessary component #12580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`-environment:main` is always instance-specific (because it is dependent on the boot options that are specified when creating the instance). Therefore it is unncessary (and confusing) to register it on the `Application` just to have it always overriden by something else on the `ApplicationInstance`.
chancancode
force-pushed
the
rm_registering_unncessary_components
branch
from
06c09bf
to
3aa1b62
Compare
rwjblue
added a commit
that referenced
this pull request
Nov 10, 2015
…components Remove registering unncessary component
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When application-visit is enabled, both
renderer:-domand-environment:mainare always instance-specific, because they aredependent on the boot options that are specified when creating the
instance. Therefore it is unncessary (and confusing) to register them on
the
Applicationjust to have them always overriden by something else onthe
ApplicationInstance.cc @krisselden