[REFACTOR removing ember global] #12592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiwiupover
changed the title
kiwiupover
force-pushed
the
replace_ember.deprecate_with_deprecate
branch
from
46842da
to
2ecce0f
Compare
|
Looks good to me. Is the testem version change required still? I thought the upstream issues were fixed... |
|
@rwjblue no the testem change is not needed. It was a change I made to fix the test run. I will revert that and push again. Cheers |
kiwiupover
force-pushed
the
replace_ember.deprecate_with_deprecate
branch
from
2ecce0f
to
669d321
Compare
mixonic
added a commit
that referenced
this pull request
Nov 12, 2015
…h_deprecate [REFACTOR removing ember global]
|
Thanks @kiwiupover! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
Ember.deprecatein favour of `deprecateMoving towards removing the Ember global