[PERF] Fix Mixin shape issues #12612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Q: do we remove debugSeal for prod builds?
I would like to, but this one is tricky. I suspect a big toString cleanup should happen, there are like 3-4 ways to accomplish it. It would be nice to unify (while still supporting module + global paths) |
krisselden
force-pushed
the
fix-mixin-shape
branch
from
37b3a6d
to
9a6da96
Compare
krisselden
force-pushed
the
fix-mixin-shape
branch
from
9a6da96
to
4b2d6d4
Compare
|
@homu r+ |
|
📌 Commit 4b2d6d4 has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Nov 16, 2015
[PERF] Fix Mixin shape issues Fix #12606 Make Mixin monomorphic and use debugSeal in development builds to flag issues.
|
Bug report incoming, but https://github.com/emberjs/ember.js/blob/master/packages/ember-runtime/lib/system/namespace.js#L221 along with the debugSeal is causing errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12606
Make Mixin monomorphic and use debugSeal in development builds to flag issues.