[DOC release] Add example and clear up wording for CP get/set #12619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ```js | ||
| let Person = Ember.Object.extend({ | ||
| firstName: 'Betty', |
There was a problem hiding this comment.
lets put these in init.
init() {
this._super(...arguments)
this.firstName = 'Betty';
this.lastName = 'Jones';
}There was a problem hiding this comment.
Done, switched both examples to this style.
SaladFork
force-pushed
the
doc-add-cp-getter-setter-example
branch
from
3df069e
to
3b0baff
Compare
|
LGTM |
|
@homu r+ |
|
📌 Commit 3b0baff has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Nov 16, 2015
…rwjblue [DOC release] Add example and clear up wording for CP get/set This PR makes the following changes to `Ember.computed` API documentation: - Changes the `fullName` getter function to match [the example in the latest guides](http://guides.emberjs.com/v2.1.0/object-model/computed-properties/). This involved changing to a template string from a string concatenation. - Switches class property default values to be defined in `init()` instead ([suggested](#12619 (comment))) - Minor changes to wording and sentence structure, mostly adding articles. - Adds an example that uses the hash format with `get` and `set` - Removes confusing/incorrect phrase: > The `get` function should accept two parameters, `key` and `value`. My one concern is that the two examples are very similar except for a few lines. Would it be more helpful if the second example only included the computed property (rather than the whole class and usage example)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes to
Ember.computedAPI documentation:Changes the
fullNamegetter function to match the example in the latest guides. This involved changing to a template string from a string concatenation.Switches class property default values to be defined in
init()instead (suggested)Minor changes to wording and sentence structure, mostly adding articles.
Adds an example that uses the hash format with
getandsetRemoves confusing/incorrect phrase:
My one concern is that the two examples are very similar except for a few lines. Would it be more helpful if the second example only included the computed property (rather than the whole class and usage example)?