add failing test for filterBy #12622
Conversation
|
@csantero I'm trying to use this test to do a git bisect, but it appears to pass on the latest release and canary. The only failures on Travis look to be styleguide related. Does that seem right? |
|
@fivetanley No that doesn't make sense, it was definitely failing last time I looked it. I'll take a look. |
csantero
force-pushed
the
filterBy-each
branch
from
4a098e8
to
88fc676
Compare
|
@fivetanley I've rebased off master and fixed the JSCS error in the test. The expected failure is appearing on travis. |
| obj = EmberObject.extend({ | ||
| a: filterBy('array', 'foo') | ||
| }).create({ | ||
| array: [a1, a2] |
There was a problem hiding this comment.
The test fails because we do not use prototype extensions by default in the test suite, so this use of a plain array is not supported. If you switch it to Ember.A([a1, a2]), the test passes.
|
This test passes when prototype extensions are enabled, so I don't think it's a real reproduction of the issue in #12475 |
|
@ef4 I see, thanks. |
DO NOT MERGE
I believe this test demonstrates behavior that used to work. The first deepEqual assertion passes but the second one fails.
This is related to #12475.
This is a duplicate of #12538, which got messed up because it was targeting release.