Implement user-helpers resolution #12917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now, I only ported two tests to show that it works.
wycats
force-pushed
the
user-helpers-lookup
branch
from
97abbc2
to
df2cb52
Compare
| @@ -23,36 +23,6 @@ QUnit.module('ember-htmlbars: custom app helpers', { | |||
| } | |||
| }); | |||
|
|
|||
| QUnit.test('dashed shorthand helper is resolved from container', function() { | |||
There was a problem hiding this comment.
Replaced by "it can resolve custom helpers"
There was a problem hiding this comment.
At first I thought the "dashed" in the name implies that we have another "test matrix" situation here, but turns out literally all the tests in this file is prefixed with "dashed"
There was a problem hiding this comment.
yes, we used to have a distinction between dashed and non-dashed, but that was removed in 1.13.
52 tasks
| registerHelper(name, funcOrClassBody) { | ||
| let type = typeof funcOrClassBody; | ||
|
|
||
| if (type === 'function') { |
There was a problem hiding this comment.
I think we should detect instances of Ember.Helper and throw before this. We do not support Ember.Helper.extend() style helpers, but typeof Ember.Helper.extend() === 'function'.
rwjblue
added a commit
that referenced
this pull request
Feb 6, 2016
Implement user-helpers resolution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now, I only ported two tests to show that it works.