with-tests #12919
Merged
with-tests #12919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds glimmer2 with tests and also refactors the conditional tests to share the basic truthy and falsy tests.
|
This looks good to me. @chancancode - r? |
|
FYI there are failing https://travis-ci.org/emberjs/ember.js/jobs/107584377#L1845
|
|
Yes, I noticed this as well. I am confused what changed from when the PR build passed Travis to when it was merged to cause this to fail... |
|
I think something went wrong with the travis webhook integration. Notice how this PR doesn't have a check mark:
|
|
D'oh! Thanks @GavinJoyce! |
Closed
|
Reverting in #12921 for now. (Sorry for the trouble on this @chadhietala) |
|
#12907 Probably should be updated to be like |
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds glimmer2 with tests and also refactors the conditional tests to
share the basic truthy and falsy tests.