[BUGFIX release] Fix legacy addon deprecations #13030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The signature of `Ember.deprecate` is `message`, `test`, `options`, where `test` is `If falsy, the deprecation will be displayed.` Here, we did the opposite, causing the deprecation message to be shown only when the addons are NOT installed. This commit fixes the issue, and also moved the deprecation to first- boot. This gives users (and our test harness) a chance to register custom handlers before we issue the warning. Also added tests.
wycats
force-pushed
the
fix-legacy-addon-deprecations
branch
from
c7d0695
to
59e9045
Compare
rwjblue
added a commit
that referenced
this pull request
Mar 1, 2016
[BUGFIX release] Fix legacy addon deprecations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signature of
Ember.deprecateismessage,test,options,where
testisIf falsy, the deprecation will be displayed.Here,we did the opposite, causing the deprecation message to be shown only
when the addons are NOT installed.