[Glimmer 2] Add support for dynamic tagName
#13145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
chancancode
added a commit
that referenced
this pull request
Mar 21, 2016
[Glimmer 2] Add support for dynamic `tagName`
| throw new Error('Not implemented: fragments (`tagName: ""`)'); | ||
| } | ||
|
|
||
| return new ValueReference(tagName || 'div'); |
There was a problem hiding this comment.
Technically, we need to support falsey tag name (tagName: '') so this will need to be tweaked as we move forward right?
There was a problem hiding this comment.
I think we also support tagName as a CP (though that should be deprecated and unlikely)
There was a problem hiding this comment.
Confirm. We are just throwing (on line 84) for now so that whoever running into this will not be confused
There was a problem hiding this comment.
Kk, gotcha. For future travelers the current implementation is https://github.com/emberjs/ember.js/blob/master/packages/ember-views/lib/system/build-component-template.js#L136-L153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.