[Glimmer 2] Implement attribute/classNameBindings #13160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
52 tasks
wycats
force-pushed
the
attribute-bindings
branch
from
5bcdec3
to
d21a3c8
Compare
| let name = attrKeys[i]; | ||
| let value = attrs[name]; | ||
|
|
||
| // Do we have to support passing both class /and/ classNames...? |
There was a problem hiding this comment.
We needed this in another branch, we will come back to this (hopefully one of the ported tests will catch it)
wycats
force-pushed
the
attribute-bindings
branch
from
d21a3c8
to
6d3d400
Compare
|
☔ The latest upstream changes (presumably #13166) made this pull request unmergeable. Please resolve the merge conflicts. |
wycats
pushed a commit
that referenced
this pull request
Mar 23, 2016
[Glimmer 2] Implement attribute/classNameBindings
This was referenced Mar 23, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.