Merge in activeTransition QPs when doing a transition #13202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raytiley
force-pushed
the
fix-clobber-activetrans-qp
branch
from
99e3cec
to
288a0f6
Compare
| @@ -1963,7 +1963,66 @@ if (isEnabled('ember-routing-route-configured-query-params')) { | |||
| equal(get(controller, 'bar'), 'rab'); | |||
| equal(get(controller, 'foo'), '456'); | |||
| }); | |||
|
|
|||
| QUnit.test('Calling transitionTo does not loose query params already on the activeTransition', function() { | |||
There was a problem hiding this comment.
This would be amazing if this issue was finally fixed, nice work! Also, tiny spelling correction here - I think you meant lose, not loose.
raytiley
force-pushed
the
fix-clobber-activetrans-qp
branch
from
288a0f6
to
2b42d56
Compare
|
Thanks! |
|
👍 woo! |
|
Included in v2.4.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12169
@ZackMattor and I paired on this at the 2016 EmberConf Contributor Workshop!