[Glimmer2] Port <input> tests to ember-glimmer #13222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paddyobrien perhaps you could add a comment to each test which has been moved/deleted as suggested in 'the process' section? This makes it easier for the reviewer. Here's an example from one of my recent PRs. |
| this.runAttributeTest('name', ['nam', 'name']); | ||
| } | ||
|
|
||
| ['@htmlbars input maxlength attribute']() { |
There was a problem hiding this comment.
htmlbars only because there seems to be a camel casing issue between maxLength and maxlength
chadhietala
added a commit
to chadhietala/ember.js
that referenced
this pull request
Apr 26, 2016
This will supersedes emberjs#13222
|
☔ The latest upstream changes (presumably #13392) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Merged as part of #13392. Thanks! |
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
This will supersedes emberjs#13222
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #13127
Port over input element tests. There are two cases that fail in glimmer which I've marked as
@htmlbars.Both failures look to be caused by missing camelization. i.e.
tabindexis the html attribute, but theHTMLInputElementproperty istabIndex