[BUGFIX beta] Ensure substates properly work with resetNamespace #14054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should target beta branch, can you prefix with |
trentmwillis
force-pushed
the
reset-substates
branch
from
414cd1b
to
9a69d63
Compare
trentmwillis
changed the title
|
@rwjblue updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two apparent issues with substates. The first was discovered when enabling substates for the
mountkeyword, but while fixing that a second seems to have been uncovered.When looking up substates, the
findChildRouteNamemethod was always applying the parent route's namespace, even if the current route hadresetNamespaceapplied. Some of the tests even seemed to be explicitly working around this issue (such as here and here), so maybe this was intended, but per the discussion in the other thread, it seems like no one currently expects it.Additionally,
_loadingsubstates were havingresetNamespaceapplied, but_errorones were not. This leads to inconsistent and unintuitive behavior. Again, maybe intended, but seems wrong.