Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release regressions. #14281

Merged
merged 2 commits into from
Sep 13, 2016
Merged

Fix release regressions. #14281

merged 2 commits into from
Sep 13, 2016

Commits on Sep 13, 2016

  1. Ensure revalidation is not triggered for destroying components. 

    Fixes regression related to `willDestroyElement` causing changes to
subscribed streams. When that happened, the system would trigger
`scheduleRevalidate` on the view (even though it was being destroyed).
By the time that the async rerender occurs the queue of things to
cleanup in `_destroyingSubtreeForView` has been reset to `null` causing
the error reported.

This fix simply avoids queueing up rerenders when the component is being destroyed.
    Robert Jackson committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    a8d05c6 View commit details
    Browse the repository at this point in the history

  2. Prevent issues during destruction when parentView is observed. 

    Setting `parentView` to `null` is technically better, but unfortunately
we have not had this reset in place for a while and folks have dependent
keys that include `parentView`. Setting without `Ember.set` triggers the
mandatory setter assertion.

This removes the clearing of `parentView` (for now) so that we can
properly message it being unobservable in the future.
    Robert Jackson committed Sep 13, 2016
    Configuration menu
    Copy the full SHA
    d62be7a View commit details
    Browse the repository at this point in the history