[FEATURE beta] Assert key in Ember.get is not empty
#14575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an assertion to let the user know when they are using an empty string as the key in `Ember.get`. Addresses [this comment](emberjs#14572 (comment)) in emberjs#14572
Serabe
force-pushed
the
feature/assert-key-not-empty
branch
from
f26c32e
to
d03ff1f
Compare
Serabe
changed the title
Ember.get is not empty if '' not `inEmber.get is not empty
rwjblue
approved these changes
Nov 4, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an assertion to let the user know when they are using an empty
string as key for
Ember.get.Addresses this comment in #14572