Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assert that a component tagName can not be a computed property #14750

Merged
merged 1 commit into from
Dec 23, 2016

Conversation

GavinJoyce
Copy link
Member

@GavinJoyce GavinJoyce commented Dec 22, 2016

fixes #14749

Component.extend({
  tagName: computed(function() {
    return 'foo-bar';
  })
});

Now produces an assertion:

You cannot use a computed property for the component's `tagName` (<(subclass of Ember.Component):ember445>)

@GavinJoyce GavinJoyce changed the title [wip] assert that a component tagName can not be a computed property assert that a component tagName can not be a computed property Dec 22, 2016
@locks
Copy link
Contributor

locks commented Dec 22, 2016

@GavinJoyce do you mean "for the component's tagName"? Otherwise it sounds like the component is named tagName to me.

@GavinJoyce
Copy link
Member Author

GavinJoyce commented Dec 22, 2016

@locks that's better, thanks

@rwjblue rwjblue merged commit f4d573e into emberjs:master Dec 23, 2016
@rwjblue
Copy link
Member

rwjblue commented Dec 23, 2016

Thanks @GavinJoyce!

@GavinJoyce GavinJoyce deleted the gj/assert-tagName-cp branch December 23, 2016 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Components with a computed tagName throw an error when trying to render
3 participants