[BUGFIX beta] only defProp the deprecated container once per prototype #15008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we defProp once pre FactoryManager.prototype.create.
|
Woah, this is pretty hefty: emberaddons.com before:
After:
|
chadhietala
approved these changes
Mar 14, 2017
|
cc @rwjblue just a note, we gotta make shit this lands in beta. |
rwjblue
reviewed
Mar 14, 2017
| @@ -559,6 +559,7 @@ function factoryInjectionsFor(container, fullName) { | |||
|
|
|||
| // TODO - remove when Ember reaches v3.0.0 | |||
| function injectDeprecatedContainer(object, container) { | |||
| if ('container' in object) { return; } | |||
There was a problem hiding this comment.
This isn't quite right, but it may not matter at this point. In the case above (in instantiate) where we are creating an instance on a factory that does not have .extend we have to ensure that the .container property on the instance (which may be the container._fakeContainerToInject is replaced by a getter that issues a deprecation.
Now, considering that this has been deprecated for quite some time (since ember 2.3), it's might be fine to drop support for the deprecation in this odd edge case.
I'll work up a failing test case so you can see what I mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we defProp once pre FactoryManager.prototype.create.
So if you have 3500 models of the same type, we defProp its class's prototype 3500 times instead of once.