Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX Release]fix mocha blueprint service test filename #15138

Merged
merged 1 commit into from
May 2, 2017

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Apr 13, 2017

Maybe this pr is incomplete, or I could add test in someway (even if this looks to be tested here: https://github.com/emberjs/ember.js/blob/master/node-tests/blueprints/service-test.js#L180,

but when I'm doing
ember g service blah, it gives the results

installing service
  create app/pods/blah/service.js
installing service-test
  create tests/unit/pods/blah/service-test-test.js

Maybe all the test's blueprints filename should be rename 'test.js' ? In that case tell me, and I could complete this pr

@Turbo87
Copy link
Member

Turbo87 commented Apr 22, 2017

@sly7-7 could you add a test similar to https://github.com/emberjs/ember.js/blob/master/node-tests/blueprints/service-test.js#L170-L184 to verify that everything works as planned?

@stefanpenner
Copy link
Member

@sly7-7 can you address @Turbo87 feedback?

@sly7-7
Copy link
Contributor Author

sly7-7 commented May 2, 2017

@stefanpenner @Turbo87 Will do that, sorry for the delay, I was on vacation.

@sly7-7 sly7-7 force-pushed the fix-mocha-service-test-blueprint branch from acc4217 to 91e1e17 Compare May 2, 2017 12:16
@sly7-7
Copy link
Contributor Author

sly7-7 commented May 2, 2017

@stefanpenner @Turbo87 Should be good now. Out of curiosity, are those tests running on travis ?

@Turbo87
Copy link
Member

Turbo87 commented May 2, 2017

Out of curiosity, are those tests running on travis ?

yes, see https://github.com/emberjs/ember.js/blob/master/.travis.yml#L64

@rwjblue rwjblue merged commit 7e0af2e into emberjs:master May 2, 2017
@rwjblue
Copy link
Member

rwjblue commented May 2, 2017

Thank you!

@sly7-7 sly7-7 deleted the fix-mocha-service-test-blueprint branch May 2, 2017 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants