[BUGFIX beta] [PERF] Cleanup Proxy #15150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
reviewed
Apr 17, 2017
| @@ -141,6 +135,8 @@ export default Mixin.create({ | |||
| !this.isController, | |||
| { id: 'ember-runtime.controller-proxy', until: '3.0.0' } | |||
| ); | |||
| return set(content, key, value); | |||
| let ret = set(content, key, value); | |||
| tagFor(this).contentDidChange(); | |||
There was a problem hiding this comment.
should this just be m._tag.contentDidChange since it is looked up at the start of setUnknownProperty?
stefanpenner
force-pushed
the
cleanup-proxy
branch
2 times, most recently
from
fa57f34
to
f0ecedc
Compare
|
looks good |
|
test failures: |
|
In chrome (for prod builds) i get a very different set of failures... Strange. |
stefanpenner
force-pushed
the
cleanup-proxy
branch
from
f0ecedc
to
5480e49
Compare
|
@krisselden I took the approach your recommended instead. And noticed some other related redundant codez. |
stefanpenner
force-pushed
the
cleanup-proxy
branch
from
5480e49
to
3915ab4
Compare
|
@krisselden stuff is green, this is ready for your 👀 |
krisselden
approved these changes
Apr 24, 2017
|
update to bug fix beta (get on todays beta) |
stefanpenner
changed the title
stefanpenner
force-pushed
the
cleanup-proxy
branch
from
3915ab4
to
b88afee
Compare
* remove `on(‘init`, just use the existing `init` * remove redundant meta lookups * remove observer (notify proxy change from a unified place, within markObjectAsDirty) * remove double `tag` lookups * remove redundant meta guards * misc cleanup
stefanpenner
force-pushed
the
cleanup-proxy
branch
from
b88afee
to
b45ee9d
Compare
rwjblue
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on(‘init, just use the existinginittaglookups