Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fixed issue when passing false to activeClass would break things #15265

Merged
merged 1 commit into from
Sep 14, 2017
Merged

[BUGFIX] fixed issue when passing false to activeClass would break things #15265

merged 1 commit into from
Sep 14, 2017

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented May 21, 2017 •
edited
Loading

this might have caused issues when activeClass falsy value would make ember-transitioning-in and ember-transitioning-out incorrectly get appended

@bekzod
Copy link
Contributor Author

bekzod commented May 21, 2017 •
edited
Loading

possibly fixes #10195 if that still an issue

@bekzod bekzod force-pushed the compute-active branch 2 times, most recently from ec4cdfc to a5938d9 Compare May 21, 2017 17:46
@bekzod bekzod changed the title refactor _computeActive to return boolean value in link-to fixed issue when passing false to activeClass would break things May 21, 2017
@bekzod bekzod changed the title fixed issue when passing false to activeClass would break things [BUGFIX] fixed issue when passing false to activeClass would break things May 21, 2017
@homu
Copy link
Contributor

homu commented May 30, 2017

☔ The latest upstream changes (presumably #15303) made this pull request unmergeable. Please resolve the merge conflicts.

@bekzod bekzod force-pushed the compute-active branch 2 times, most recently from e1d8adb to 53d3ef8 Compare June 1, 2017 10:29
@rwjblue
Copy link
Member

rwjblue commented Sep 13, 2017

Changes seem good, but I think this needs a rebase now.

@locks
Copy link
Contributor

locks commented Sep 13, 2017

@bekzod can you squash the commits, please?

@bekzod
Copy link
Contributor Author

bekzod commented Sep 14, 2017

@locks done :P

@locks locks requested a review from rwjblue September 14, 2017 10:41
@rwjblue rwjblue merged commit b27344a into emberjs:master Sep 14, 2017
@bekzod bekzod deleted the compute-active branch September 14, 2017 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue Awaiting requested review from rwjblue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bekzod @homu @rwjblue @locks