[FEATURE ember-engines-mount-params] Constrain to model hash arg.
#15325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After discussion during a recent core team meeting, the original
implementation (and RFC) were determined to be a bit future hostile.
Specifically, with the implementation prior to this PR it would have
been impossible to add any additional hash arguments that were
targeting the `{{mount` syntax directly (e.g. namespacing for use
with tree shaking) without breaking changes (since all hash arg names
were allowed to be passed through before).
This change updates things a bit to limit the pass through to the `model`
hash argument, which actually makes things a tad bit more teachable
anyways. The ability to pass down arbitrary named values is absolutely
still present through the usage of the `(hash` helper.
|
/cc @mike183 |
|
👍 Thanks for the heads up. |
|
Sweet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion during a recent core team meeting, the original implementation
(and RFC) were determined to be a bit future hostile.
Specifically, with the implementation prior to this PR it would have been impossible to add any additional hash arguments that were targeting the
{{mountsyntax directly (e.g. namespacing for use with tree shaking) without breaking changes (since all hash arg names were allowed to be passed through before).This change updates things a bit to limit the pass through to the
modelhash argument, which actually makes things a tad bit more teachable anyways. The ability to pass down arbitrary named values is absolutely still present through the usage of the(hashhelper.