[BUGFIX beta] Ensure helpers have a consistent API. #15848
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having class based helpers return a different API from "simple" helpers is quite confusing. It makes testing a helper significantly different based on the type of helper, and also makes refactoring from simple to class-based a hazzard.
This change ensures that both types of helper return the same basic interface, and enables us to use output similar to the following regardless of the specific type of helper that was exported: