Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CLEANUP] Remove Enumerable#contains #15889

Merged
merged 1 commit into from
Nov 30, 2017
Merged

[CLEANUP] Remove Enumerable#contains #15889

merged 1 commit into from
Nov 30, 2017

Conversation

cibernox
Copy link
Contributor

@cibernox cibernox commented Nov 29, 2017 •
edited
Loading

Part of #15876

@cibernox cibernox changed the title [CLEANUP] Remove Enumerable#includes [CLEANUP] Remove Enumerable#contains Nov 29, 2017
@cibernox cibernox mentioned this pull request Nov 29, 2017
Closed
34 tasks
@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2017

Looks good to me! Can you add an issue an issue on emberjs/ember-2-legacy for this one, and cross link back here?

@cibernox cibernox mentioned this pull request Nov 30, 2017
Closed
@cibernox
Copy link
Contributor Author

Cross issued created. I'll implement it too.

@rwjblue rwjblue merged commit c27cd04 into emberjs:master Nov 30, 2017
@rwjblue
Copy link
Member

rwjblue commented Nov 30, 2017

Awesome, thank you!

@cibernox cibernox deleted the remove-enumerable-contains branch December 2, 2017 17:11
@bekzod bekzod mentioned this pull request Dec 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cibernox @rwjblue