[CLEANUP] removed providing reversed arguments to observer
#15893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
force-pushed
the
remove-reverse-args-observer
branch
from
ac89968
to
1f71415
Compare
bekzod
commented
Nov 30, 2017
| @@ -842,22 +833,12 @@ export function _immediateObserver() { | |||
| @private | |||
| */ | |||
| export function _beforeObserver(...args) { | |||
There was a problem hiding this comment.
removed providing reversed arguments to _beforeObserver too
bekzod
force-pushed
the
remove-reverse-args-observer
branch
from
1f71415
to
e383e1d
Compare
|
Can you create a corresponding PR (or issue that links back here) at https://github.com/emberjs/ember-2-legacy? All of the API functionality we remove from this repo for 3.0 must be "re-enableable" by including that addon. |
|
done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.