[CLEANUP] Remove {{render}} #15915
Merged
[CLEANUP] Remove {{render}} #15915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue I don't have a great way of getting rid of these other files other than putting a comment on them for future removal. Do you have any ideas? Right now I'm just making sure that we don't include render is what we want, just not sure if we can clean this up any more |
rwjblue
reviewed
Dec 6, 2017
| @@ -65,7 +65,11 @@ export function registerMacros(macro: any) { | |||
| export function populateMacros(blocks: any, inlines: any) { | |||
| inlines.add('outlet', outletMacro); | |||
| inlines.add('component', inlineComponentMacro); | |||
| inlines.add('render', renderMacro); | |||
|
|
|||
| if (ENV._ENABLE_RENDER_SUPPORT === true) { | |||
There was a problem hiding this comment.
I think this ENV is not imported (thats what one of the test failures indicated at least)..
There was a problem hiding this comment.
@thoov - I think fixing this will fix CI.
There was a problem hiding this comment.
@rwjblue Yep that fixed it. Should be good to go now
rwjblue
approved these changes
Dec 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ember-2-legacy PR
Apart of: #15876