Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] fix regression of clicking link-to with disabled=true #15952

Merged
merged 3 commits into from
Dec 22, 2017
Merged

[BUGFIX beta] fix regression of clicking link-to with disabled=true #15952

merged 3 commits into from
Dec 22, 2017

Commits on Dec 22, 2017

  1. [BUGFIX beta] fix regression of clicking link-to with disabled=true

    @simonihmig @rwjblue
    simonihmig authored and rwjblue committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    85d4483 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX beta] Refactor disabled system in {{link-to}}. 

    The prior system was overly complicated (it still kinda is, but thats a
story for a future refactor). It relied on the fact that `_isDisabled`
was set to disable the link-to (either via hitting the `disabled` CPs
setter, or via passing `disabledWhen`) and then checked `_isDisabled`
when being invoked.

The original issue was that we were _always_ setting `_isDisabled` to
false in the constructor (done to ensure `link-to` has a consistent
shape). That was fixed by pre-sloting `_isDisabled` _before_ calling
`this._super` (yes, I know thats generally bad, but so is our
`Object.assign(instance, properties)` that runs _before_ `init`).
    @rwjblue
    rwjblue committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    63ff892 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX release] Cleanup documentation for {{link-to}}.

    @rwjblue
    rwjblue committed Dec 22, 2017
    Configuration menu
    Copy the full SHA
    c5b3626 View commit details
    Browse the repository at this point in the history