[BUGFIX beta] Fix various issues with descriptor trap. #16169
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid adding enumerable properties to Array.prototype.
Ember.NativeArray
is a normal Ember.Mixin that we mix intoArray.prototype
when prototype extensions are enabled. Mutating a native object prototype like this should not result in enumerable properties being added (or we have significant issues with things like deep equality checks from test frameworks, or things likejQuery.extend(true, [], [])
). This is a hack, and we should stop mutating the array prototype by default. 😫Cache the descriptor trap. Prior to this change, a new proxy was created for every property access. This resulted in some pretty bizarre semantics. Consider the following:
O_o
String.prototype
.Function.prototype
.