[BUGFIX beta] Ensure accessing a "proxy" itself does not error. #16274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, if `Ember.get` (or `this.get`) is used to access a property that is an Ember.Object with an `unknownProperty` that always returns a non-`undefined` value, the internals of `Ember.get` would check if that property is a "descriptor" and (due to the `unknownProperty` never returning `undefined`) the dev time assertion for accessing a proxy's content without using `Ember.get` would be triggered.
|
/cc @wagenet |
|
For completeness, we may want to mention that this should also resolve a similar situation where the proxy's content was destroyed and certain types of access to destroyed objects would raise assertions. |
wagenet
approved these changes
Feb 23, 2018
|
❤️ :party: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, if
Ember.get(orthis.get) is used to access a property that is an Ember.Object with anunknownPropertythat always returns a non-undefinedvalue, the internals ofEmber.getwould check if that property is a "descriptor" and (due to theunknownPropertynever returningundefined) the dev time assertion for accessing a proxy's content without usingEmber.getwould be triggered.Fixes #16263