Add prettier to linting configuration. #16440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that prettier usage is "enforced", but also allows nice things like `eslint --fix .` (or related in-editor fixers).
This commit is the result of `eslint --fix .` (aka completed automated).
After running prettier across the codebase a few additional linting errors cropped up.
Makes fixing these linting issues much nicer...
krisselden
approved these changes
Mar 29, 2018
|
@mmun why is it controversial? I really think it helps for deciding a style for max line length issues, and it works with typescript and js |
I think that was a specific comment around trailing commas... |
|
@rwjblue Yeah, sorry. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn lint:fixcommand to easily "autofix" linting errorsIt will be much easier to review this PR commit by commit as the bulk of the changes are purely mechanical (
yarn eslint --fix .). The first commit contains all of the prettier configuration / setup:a49b007