Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLEANUP beta] #16391 Cleaning up the test output #16468

Merged
merged 1 commit into from
Apr 5, 2018
Merged

[CLEANUP beta] #16391 Cleaning up the test output #16468

merged 1 commit into from
Apr 5, 2018

Conversation

KamiKillertO
Copy link
Contributor

@KamiKillertO KamiKillertO commented Apr 5, 2018

This PR remove the error message More context objects were passed than there are dynamic segments for route: stink-bomb. (Quest #16391)

I've just override console.error with a noop function.

@rwjblue
Copy link
Member

rwjblue commented Apr 5, 2018

I just confirmed that the modules teardown properly resets console.error, good job!

@rwjblue rwjblue merged commit 3f901df into emberjs:master Apr 5, 2018
@KamiKillertO KamiKillertO deleted the clean-up-test-output branch April 27, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants