Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ComponentDefinitions do not leak heap space. #16558

Merged
merged 3 commits into from
Apr 21, 2018
Merged

Ensure ComponentDefinitions do not leak heap space. #16558

merged 3 commits into from
Apr 21, 2018

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 20, 2018

Addresses #16503

@rwjblue rwjblue added this to the v3.1.x milestone Apr 20, 2018
@rwjblue rwjblue requested a review from krisselden April 20, 2018 21:55
@rwjblue rwjblue mentioned this pull request Apr 20, 2018
Closed
@rwjblue rwjblue merged commit 0244f03 into master Apr 21, 2018
@rwjblue rwjblue deleted the component-definition-leak branch April 21, 2018 13:46
@krisselden
Copy link
Contributor

I'm pretty cure we could just use a Map, and use the component or the template if there is no component as the key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krisselden krisselden Awaiting requested review from krisselden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@rwjblue @krisselden